Skip to content

fix(web): close model selector before opening provider dialogs - #14173

Open
HariomPCode wants to merge 3 commits into
onyx-dot-app:mainfrom
HariomPCode:main
Open

fix(web): close model selector before opening provider dialogs#14173
HariomPCode wants to merge 3 commits into
onyx-dot-app:mainfrom
HariomPCode:main

Conversation

@HariomPCode

@HariomPCode HariomPCode commented Aug 22, 2026

Copy link
Copy Markdown

Description

Fixes the model selector popover remaining visually open when another model-related dialog is opened.

The ModelSelector now supports controlled open state, allowing the Language Models page to close the Default Model selector before opening a provider configuration dialog.

Fixes #14172

How Has This Been Tested?

  • Manually verified the Default Model selector can be opened and closed normally.
  • Verified that opening a provider configuration dialog closes the Default Model selector.
  • Verified the stale, non-interactive dropdown no longer remains visible over the dialog.

Additional Options

  • [Optional] Please cherry-pick this PR to the latest release version.
  • [Optional] Override Linear Check

Summary by cubic

Closes the Default Model selector before opening any provider modal, preventing a stale popover from overlaying dialogs. Previously the popover stayed visible over provider config and delete dialogs; now the page controls the popover and closes it first.

  • Adds optional open and onOpenChange props to ModelSelector; falls back to internal state when not provided.
  • LanguageModelsPage tracks the selector’s open state and closes it via onBeforeOpen before opening Existing/New/Custom provider configuration modals and the delete modal.
  • No breaking changes; existing uncontrolled usages continue to work.

Written for commit 8f4523c. Summary will update on new commits.

Review in cubic

@HariomPCode
HariomPCode requested a review from a team as a code owner August 22, 2026 15:24
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread web/src/views/admin/LanguageModelsPage.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default model dropdown remains visible when opening another model configuration dialog

1 participant