fix(web): close model selector before opening provider dialogs - #14173
Open
HariomPCode wants to merge 3 commits into
Open
fix(web): close model selector before opening provider dialogs#14173HariomPCode wants to merge 3 commits into
HariomPCode wants to merge 3 commits into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the model selector popover remaining visually open when another model-related dialog is opened.
The
ModelSelectornow supports controlled open state, allowing the Language Models page to close the Default Model selector before opening a provider configuration dialog.Fixes #14172
How Has This Been Tested?
Additional Options
Summary by cubic
Closes the Default Model selector before opening any provider modal, preventing a stale popover from overlaying dialogs. Previously the popover stayed visible over provider config and delete dialogs; now the page controls the popover and closes it first.
openandonOpenChangeprops toModelSelector; falls back to internal state when not provided.LanguageModelsPagetracks the selector’s open state and closes it viaonBeforeOpenbefore opening Existing/New/Custom provider configuration modals and the delete modal.Written for commit 8f4523c. Summary will update on new commits.